Fix SST thread not taking effect #173
Merged
+86
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalvinNeo
reviewed
Sep 17, 2022
|
|
||
| // This pool is used when handling ingest SST raft messages, e.g. | ||
| // when using BR / lightning. | ||
| sst_handle_pool_size: (cpu_num * 0.3).clamp(2.0, 8.0) as usize, |
There was a problem hiding this comment.
Why not using apply_raft_batch_system.low_priority_pool_size directly?
CalvinNeo
reviewed
Sep 17, 2022
| @@ -286,7 +286,6 @@ pub unsafe fn run_proxy( | |||
| fatal!("unknown configuration options: {}", e); | |||
| } | |||
| } | |||
| crate::config::address_proxy_config(&mut config); | |||
There was a problem hiding this comment.
why? address_proxy_config will also do some checkings.
There was a problem hiding this comment.
This address have no effect, becuase the process then exited.
There was a problem hiding this comment.
Yes, this is a config check, if address_proxy_config can't pass, it will call fatal which print out a error log
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
CalvinNeo
approved these changes
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wish [email protected]
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
Override the low-apply thread pool size using a Proxy customized config.
Check List
Tests
Side effects
Documentation
Release note