Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: set sentry env as option in gulp #923

Closed
wants to merge 5 commits into from

Conversation

unbyte
Copy link
Contributor

@unbyte unbyte commented May 12, 2021

also provide a fallback hash string.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@unbyte
Copy link
Contributor Author

unbyte commented May 12, 2021

besides, windows doesn't support key=value command 🌚

@ti-chi-bot ti-chi-bot requested a review from breezewish May 12, 2021 08:41
@ti-chi-bot
Copy link
Member

@unbyte: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @breeswish PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@unbyte unbyte closed this May 12, 2021
@unbyte unbyte reopened this May 12, 2021
@unbyte unbyte marked this pull request as draft May 12, 2021 09:28
@unbyte unbyte force-pushed the refine-sentry-env branch from 41780d7 to 5b6660d Compare May 12, 2021 09:30
@breezewish
Copy link
Member

I think we can prefer #930 over this PR. Close for now! :)

@breezewish breezewish closed this Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants