keyviz: support obtaining table info with clustered index from tidb #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zheng Xiangsheng <[email protected]>
Signed-off-by: Zheng Xiangsheng <[email protected]>
Signed-off-by: Zheng Xiangsheng <[email protected]>
Signed-off-by: Zheng Xiangsheng <[email protected]>
Signed-off-by: Zheng Xiangsheng <[email protected]>
Signed-off-by: Zheng Xiangsheng <[email protected]>
Signed-off-by: Zheng Xiangsheng <[email protected]>
Signed-off-by: Zheng Xiangsheng <[email protected]>
Signed-off-by: Zheng Xiangsheng <[email protected]>
Signed-off-by: Zheng Xiangsheng <[email protected]>
# Conflicts: # pkg/keyvisual/matrix/average.go # pkg/keyvisual/matrix/distance.go # pkg/keyvisual/matrix/distance_test.go # pkg/keyvisual/storage/region.go # pkg/keyvisual/storage/stat.go
Signed-off-by: HunDunDM <[email protected]>
Signed-off-by: HunDunDM <[email protected]>
Signed-off-by: HunDunDM <[email protected]>
baurine
approved these changes
Mar 12, 2021
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
|
except the codec.go (I didn't review the codec.go file), others look fine. |
|
/lgtm |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 775fab7
|
breezewish
pushed a commit
that referenced
this pull request
Mar 12, 2021
breezewish
added a commit
that referenced
this pull request
Mar 12, 2021
* use cache for slow query and statements (#828) * Optimize slow-query list (#835) * keyviz: fix the bug that table info cannot be obtained if the database name contains special chars (#840) * ui: remember the coarse scrolled position for statements and slow queries list (#843) * ui: refine page change statistics (#839) * fix slow query bug when order by other fields (#838) * config: fix the bug that the dynamic config cannot be obtained when the PD starts later than the dashboard server (#842) * Add placeholders for using scaffold (#844) * ui: add more shared session expired duration options (#849) * Fix(ui): Fix statemtent list initial loading (#846) * Update github.com/oleiade/reflections to v1.0.1 to avoid checksum mismatch (#850) * update package name (#857) * keyviz: support obtaining table info with clustered index from tidb (#845)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codecFor clustered index, please refer to tidb#4841