Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add share code revoke api; add a config to allow disabling custom prom addr (#1717) #1752

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1717

  • add share code revoke api: In the past, we could not revoke the authorization code obtained through "Share TiDB Dashboard Sessions" and could only wait for it to expire. I added a new API to revoke all authorization codes by resetting the key.
  • add a config to allow disabling custom prom addr: For security reasons, we need to introduce a configuration item to disable the custom promtheus address to avoid SSRF attacks.

Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2024

@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 7, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baurine, mornyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 7, 2024
@ti-chi-bot ti-chi-bot bot removed the lgtm label Nov 7, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-07 03:04:29.984111269 +0000 UTC m=+1096582.823266800: ☑️ agreed by baurine.
  • 2024-11-07 03:04:37.006985311 +0000 UTC m=+1096589.846140851: ✖️🔁 reset by baurine.

Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2024

New changes are detected. LGTM label has been removed.

@baurine baurine merged commit cea31b0 into pingcap:release-7.1 Nov 7, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants