Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security fixes #1592

Merged
merged 1 commit into from
Sep 15, 2023
Merged

security fixes #1592

merged 1 commit into from
Sep 15, 2023

Conversation

mornyx
Copy link
Collaborator

@mornyx mornyx commented Sep 15, 2023

  • Two SQL injection vulnerabilities
  • The middleware is not aborted after JWT validation failure

Signed-off-by: mornyx <[email protected]>
@ti-chi-bot ti-chi-bot bot requested review from baurine and breezewish September 15, 2023 03:45
@netlify
Copy link

netlify bot commented Sep 15, 2023

Deploy Preview for tidb-dashboard canceled.

Name Link
🔨 Latest commit ca41da2
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/6503d3684b59340008fc8043

@ti-chi-bot ti-chi-bot bot added the size/S label Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #1592 (ca41da2) into master (2fe49a6) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1592      +/-   ##
==========================================
- Coverage   24.71%   24.70%   -0.01%     
==========================================
  Files         169      169              
  Lines       15211    15216       +5     
==========================================
  Hits         3759     3759              
- Misses      11170    11175       +5     
  Partials      282      282              
Flag Coverage Δ
backend_integration 9.31% <0.00%> (-0.01%) ⬇️
backend_ut 26.41% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fe49a6...ca41da2. Read the comment docs.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shhdgit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 15, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-15 03:51:28.945300132 +0000 UTC m=+230254.912888168: ☑️ agreed by shhdgit.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 15, 2023
@ti-chi-bot ti-chi-bot bot merged commit eb87a09 into master Sep 15, 2023
@ti-chi-bot ti-chi-bot bot deleted the mornyx/security branch September 15, 2023 03:52
mornyx added a commit that referenced this pull request Sep 20, 2023
mornyx added a commit that referenced this pull request Sep 20, 2023
baurine pushed a commit that referenced this pull request Sep 21, 2023
* security fixes (#1592)

* hide full stacktrace info in error message (#1593)

* update release-version to 2023.09.21.1

Signed-off-by: mornyx <[email protected]>

---------

Signed-off-by: mornyx <[email protected]>
mornyx added a commit that referenced this pull request Sep 21, 2023
mornyx added a commit that referenced this pull request Sep 21, 2023
* security fixes (#1592)

* hide full stacktrace info in error message (#1593)
mornyx added a commit that referenced this pull request Oct 16, 2023
* security fixes (#1592)

* hide full stacktrace info in error message (#1593)

* update release-version to 2023.09.21.1

Signed-off-by: mornyx <[email protected]>

---------

Signed-off-by: mornyx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants