Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 3.0 rebase master #587

Merged
merged 6 commits into from
May 7, 2019
Merged

release 3.0 rebase master #587

merged 6 commits into from
May 7, 2019

Conversation

WangXiangUSTC
Copy link
Contributor

What problem does this PR solve?

rebase master

What is changed and how it works?

git rebase master

july2993 and others added 6 commits April 30, 2019 15:29
* More tests for arbiter

* Log os.Hostname error
#572)

* Refactor, eliminate duplicate code by introducing a taskGroup

* Use zap.Stack directly
* Add tests for drainer

* Use DeepEquals to simplify map testing

* Just import context

* Use Equals
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ suzaku
✅ WangXiangUSTC
✅ ceohockey60
❌ july2993
You have signed the CLA already but the status is still pending? Let us recheck it.

@suzaku
Copy link
Contributor

suzaku commented May 7, 2019

/run-all-tests

@suzaku
Copy link
Contributor

suzaku commented May 7, 2019

LGTM

@IANTHEREAL IANTHEREAL merged commit 8ff1c75 into release-3.0 May 7, 2019
@IANTHEREAL IANTHEREAL deleted the xiang/rebase branch May 7, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants