drainer: history job need sort by schema version #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-all-tests |
|
refine |
added 2 commits
January 16, 2019 19:53
july2993
reviewed
Jan 16, 2019
| @@ -179,3 +185,20 @@ func filterIgnoreSchema(schema *model.DBInfo, ignoreSchemaNames map[string]struc | |||
| _, ok := ignoreSchemaNames[schema.Name.L] | |||
| return ok | |||
| } | |||
|
|
|||
| // jobsSorter implements the sort.Interface interface. | |||
| type jobsSorter struct { | |||
There was a problem hiding this comment.
why not just like type JobsBySchemaVersion []*model.Job
and sort.Sort(JobsBySchemaVersion(jobs))
There was a problem hiding this comment.
just same with tidb's code
https://github.com/pingcap/tidb/blob/f522de2e8fea1f9b7e32dda9522f0e8df59f4da4/meta/meta.go#L693
it dosen't matter
|
PTAL again @GregoryIan @july2993 |
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
amyangfei
reviewed
Jan 21, 2019
Co-Authored-By: WangXiangUSTC <[email protected]>
amyangfei
approved these changes
Jan 21, 2019
july2993
approved these changes
Jan 21, 2019
WangXiangUSTC
added a commit
that referenced
this pull request
Jan 24, 2019
july2993
pushed a commit
that referenced
this pull request
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
issue：https://internal.pingcap.net/jira/browse/TOOL-823
get history ddl job from tidb return ddl job order by job id, job finished earlier may have bigger job id, should sort the job by schema version, or may meet
table not founderrorWhat is changed and how it works?
sort job id by schema version
Check List
Tests
Related changes