Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/* add swap unique index value test #437

Merged
merged 3 commits into from
Jan 17, 2019
Merged

tests/* add swap unique index value test #437

merged 3 commits into from
Jan 17, 2019

Conversation

july2993
Copy link
Contributor

@july2993 july2993 commented Jan 7, 2019

What problem does this PR solve?

add a test to swap two unique index key value
just enhancement test

What is changed and how it works?

add in integrate test

Check List

Tests

  • Integration test
    Code changes

Side effects

Related changes

@july2993
Copy link
Contributor Author

july2993 commented Jan 7, 2019

/run-all-tests

@july2993
Copy link
Contributor Author

july2993 commented Jan 7, 2019

/run-integration-test

@WangXiangUSTC
Copy link
Contributor

LGTM

@july2993
Copy link
Contributor Author

july2993 commented Jan 8, 2019

@GregoryIan PTAL

IANTHEREAL
IANTHEREAL approved these changes Jan 17, 2019
View reviewed changes
Copy link
Collaborator

@IANTHEREAL IANTHEREAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993 july2993 merged commit 89989b1 into master Jan 17, 2019
@july2993 july2993 deleted the hjh/swap_uk_test branch January 17, 2019 03:45
july2993 added a commit that referenced this pull request Feb 26, 2019
@july2993
tests/* add swap unique index value test (#437)
784815d
@july2993 july2993 mentioned this pull request Feb 26, 2019
Merged
july2993 added a commit that referenced this pull request Feb 26, 2019
@july2993
tests/* add swap unique index value test (#437)
7e06436
july2993 added a commit that referenced this pull request Feb 26, 2019
@july2993
tests/* add swap unique index value test (#437)
01fd321
july2993 added a commit that referenced this pull request Feb 27, 2019
@july2993
cherry pick pkg/loader (#471)
b4c33a7 
* pkg/loader: add pkg to load data to mysql (#436)

* tests/* add swap unique index value test (#437)

* fix json type and may lost data when restart (#463)

* translate.go use string type instead of []byte for json field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IANTHEREAL IANTHEREAL IANTHEREAL approved these changes

Assignees
No one assigned
Labels
priority/normal status/LGT2 type/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@july2993 @WangXiangUSTC @IANTHEREAL