mysql.go: data may not consistent when no pk but has uk #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cause by drainer using uk as where to update (where a1 = * and a3 is NULL), may update the wrong row when any column is null, it will not be index, so we can't use it unless all column of index is not null
|
/run-integration-test |
|
if we have multiple unique indices, we chose any one but it contains null column, maybe it's better to chose another one, do you read code in |
|
/run-all-tests |
july2993
force-pushed
the
hjh/fix_null_uk
branch
from
a9c39dc to
2bd6284
Compare
|
/run-all-tests |
|
@GregoryIan PTAL |
|
/run-all-tests |
|
please fix ci |
|
LGTM |
|
/run-all-tests |
| } | ||
|
|
||
| columns := make(map[string]*model.ColumnInfo) | ||
| for _, col := range table.Columns { | ||
| columns[col.Name.O] = col | ||
| } | ||
|
|
||
| for _, idx := range table.Indices { | ||
| // put primary key at [0], so we get primary key first if table has primary key |
There was a problem hiding this comment.
this code seems can delete, it may make some confuse
|
/run-all-tests |
|
/run-integration-test |
|
/run-integration-test |
july2993
added a commit
that referenced
this pull request
Dec 25, 2018
* mysql.go: data may not consistent when no pk but has uk cause by drainer using uk as where to update (where a1 = * and a3 is NULL), may update the wrong row when any column is null, it will not be index, so we can't use it unless all column of index is not null
july2993
added a commit
that referenced
this pull request
Dec 27, 2018
* mysql.go: data may not consistent when no pk but has uk cause by drainer using uk as where to update (where a1 = * and a3 is NULL), may update the wrong row when any column is null, it will not be index, so we can't use it unless all column of index is not null
july2993
added a commit
that referenced
this pull request
Dec 27, 2018
* mysql.go: data may not consistent when no pk but has uk cause by drainer using uk as where to update (where a1 = * and a3 is NULL), may update the wrong row when any column is null, it will not be index, so we can't use it unless all column of index is not null
WangXiangUSTC
pushed a commit
that referenced
this pull request
Jan 21, 2019
* mysql.go: data may not consistent when no pk but has uk cause by drainer using uk as where to update (where a1 = * and a3 is NULL), may update the wrong row when any column is null, it will not be index, so we can't use it unless all column of index is not null
WangXiangUSTC
added a commit
that referenced
this pull request
Jan 22, 2019
* mysql.go: data may not consistent when no pk but has uk cause by drainer using uk as where to update (where a1 = * and a3 is NULL), may update the wrong row when any column is null, it will not be index, so we can't use it unless all column of index is not null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
see https://internal.pingcap.net/jira/browse/TOOL-714
mysql.go: data may not consistent when no pk but has uk
cause by drainer using uk as where to update (where a1 = * and a3 is
NULL), may update the wrong row
when any column is null, it will not be index, so we can't use it unless
all column of index is not null
What is changed and how it works?
choose pk first, and check all column not null if use unique key, or use all columns
Check List
Tests
Code changes
Side effects
Related changes
kafka branch