Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drainer: fix placement policy compatibility #1119

Merged
merged 4 commits into from
Jan 13, 2022

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Jan 12, 2022

What problem does this PR solve?

Issue Number: close #1118 and close pingcap/tidb#31611

What is changed and how it works?

make drainer compatible with placement policy

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 12, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added size/XL and removed size/M labels Jan 12, 2022
@lichunzhu lichunzhu added needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 size/M and removed size/XL labels Jan 12, 2022
@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added size/XL and removed size/M labels Jan 12, 2022
@lichunzhu
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot added size/M and removed size/XL labels Jan 12, 2022
@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor Author

lichunzhu commented Jan 12, 2022

/cc glorv

@lichunzhu lichunzhu requested review from lance6716 and glorv January 12, 2022 14:45
@lichunzhu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d80dd6d

@ti-chi-bot ti-chi-bot merged commit 4fd9ebd into pingcap:master Jan 13, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout 5.4: error checking out 5.4: exit status 1. output: error: pathspec '5.4' did not match any file(s) known to git

@lichunzhu lichunzhu deleted the fixPlacementRules branch January 13, 2022 02:29
@lichunzhu
Copy link
Contributor Author

/cherry-pick release-5.4

@ti-chi-bot
Copy link
Member

@lichunzhu: new pull request created: #1120.

In response to this:

/cherry-pick release-5.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants