Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

scripts: add some metrics for tidb #830

Merged
merged 7 commits into from
Jul 19, 2019
Merged

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Jul 17, 2019

Signed-off-by: Shuaipeng Yu <[email protected]>
@jackysp jackysp requested a review from liubo0127 July 17, 2019 09:24
jackysp added 2 commits July 17, 2019 17:25
Signed-off-by: Shuaipeng Yu <[email protected]>
Signed-off-by: Shuaipeng Yu <[email protected]>
Signed-off-by: Shuaipeng Yu <[email protected]>
@tiancaiamao
Copy link
Contributor

Do we have slow_query related metrics? @jackysp

@jackysp
Copy link
Member Author

jackysp commented Jul 18, 2019

Yes, already have one.

@lysu
Copy link
Contributor

lysu commented Jul 18, 2019

how about add

  • process_open_fds identify socket fd problem(mainly to tikv side connection increase)
  • go_memstats_gc_cpu_fraction percent between 0 to 1
  • go_memstats_heap_inuse maybe need change to go_memstats_heap_alloc_bytes? https://golang.org/pkg/runtime/#MemStats(maybe we can copy comments to metric's description)
  • sum(tidb_tikvclient_pending_batch_requests) by (instance) => sum(tidb_tikvclient_pending_batch_requests) by (store)
  • maybe we need add tidb_tikvclient_lock_cleanup_task_total and tidb_tikvclient_range_task_stats with its labels?

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@jackysp
Copy link
Member Author

jackysp commented Jul 18, 2019

how about add

  • process_open_fds identify socket fd problem(mainly to tikv side connection increase)
    good idea
  • go_memstats_gc_cpu_fraction percent between 0 to 1
    ok
  • go_memstats_heap_inuse maybe need change to go_memstats_heap_alloc_bytes? https://golang.org/pkg/runtime/#MemStats(maybe we can copy comments to metric's description)
    ok, but I firstly do not want to change the existed formula.
  • sum(tidb_tikvclient_pending_batch_requests) by (instance) => sum(tidb_tikvclient_pending_batch_requests) by (store)
    ok, but I'm afraid the num of tikv will be so many.
  • maybe we need add tidb_tikvclient_lock_cleanup_task_total and tidb_tikvclient_range_task_stats with its labels?
    They're already there.

jackysp added 2 commits July 18, 2019 22:04
Signed-off-by: Shuaipeng Yu <[email protected]>
Signed-off-by: Shuaipeng Yu <[email protected]>
@jackysp
Copy link
Member Author

jackysp commented Jul 18, 2019

PTAL @lysu

Signed-off-by: Shuaipeng Yu <[email protected]>
@lysu
Copy link
Contributor

lysu commented Jul 19, 2019

LGTM

@lysu lysu added the LGT1 label Jul 19, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit 7488e6c into pingcap:master Jul 19, 2019
jackysp added a commit to jackysp/tidb-ansible that referenced this pull request Jul 26, 2019
@jackysp jackysp deleted the add_tidb_metrics branch March 18, 2020 06:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants