This repository has been archived by the owner on Jun 24, 2021. It is now read-only.
scripts: update the KV metrics on TiDB #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shuaipeng Yu <[email protected]>
coocood
reviewed
Dec 24, 2019
scripts/tidb.json
Outdated
| @@ -5688,18 +5688,18 @@ | |||
| "dashLength": 10, | |||
| "dashes": false, | |||
| "datasource": "${DS_TEST-CLUSTER}", | |||
| "description": "kv requests durations by store", | |||
| "description": "kv command total by instance and command type", | |||
Signed-off-by: Shuaipeng Yu <[email protected]>
|
LGTM |
coocood
approved these changes
Dec 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shuaipeng Yu [email protected]
Avoid using
tidb_tikvclient_txn_cmd_totalfor KV request which will confuse the user.