Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: Update TiDB Dashboard to v2021.06.15.1 (#3785) #3798

Merged
merged 7 commits into from
Jun 25, 2021

Conversation

shhdgit
Copy link
Contributor

@shhdgit shhdgit commented Jun 18, 2021

What problem does this PR solve?

This is an cherry-pick of #3785

Signed-off-by: Suhaha [email protected]

What is changed and how it works?

Check List

Update to TiDB Dashboard v2021.06.15.1

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release note

Update TiDB Dashboard to v2021.06.15.1

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 18, 2021
@ti-chi-bot ti-chi-bot requested review from disksing and JmPotato June 18, 2021 04:13
@shhdgit shhdgit changed the title Cherry pick 3785 to release 5.0 dashboard: Update TiDB Dashboard to v2021.06.15.1 (#3785) Jun 18, 2021
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #3798 (76c6f5a) into release-5.0 (65ddb56) will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.0    #3798      +/-   ##
===============================================
- Coverage        74.75%   74.52%   -0.23%     
===============================================
  Files              245      245              
  Lines            24188    24188              
===============================================
- Hits             18081    18027      -54     
- Misses            4495     4537      +42     
- Partials          1612     1624      +12     
Flag Coverage Δ
unittests 74.52% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/tempurl/tempurl.go 45.00% <0.00%> (-25.00%) ⬇️
server/region_syncer/server.go 83.33% <0.00%> (-6.07%) ⬇️
server/election/leadership.go 83.52% <0.00%> (-5.89%) ⬇️
server/tso/allocator_manager.go 74.41% <0.00%> (-5.32%) ⬇️
server/member/member.go 69.56% <0.00%> (-3.27%) ⬇️
server/schedulers/utils.go 93.10% <0.00%> (-1.38%) ⬇️
client/base_client.go 82.47% <0.00%> (-0.52%) ⬇️
server/cluster/cluster.go 82.95% <0.00%> (-0.37%) ⬇️
server/grpc_service.go 46.83% <0.00%> (-0.34%) ⬇️
server/schedule/operator/step.go 67.44% <0.00%> (-0.34%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ddb56...76c6f5a. Read the comment docs.

@shhdgit
Copy link
Contributor Author

shhdgit commented Jun 18, 2021

/label needs-cherry-pick-release-5.0

@ti-chi-bot
Copy link
Member

@shhdgit: The label(s) type/cherry-pick-for-release-5.1 cannot be applied. These labels are supported: Hacktoberfest, challenge-program, ci-unstable, compatibility-breaker, high-performance, hptc, needs-cherry-pick-release-1.0, needs-cherry-pick-release-2.0, needs-cherry-pick-release-2.1, needs-cherry-pick-release-3.0, needs-cherry-pick-release-3.1, needs-cherry-pick-release-4.0, needs-cherry-pick-release-5.0, needs-cherry-pick-release-5.1, release-note, require-LGT1, wontfix.

In response to this:

/label type/cherry-pick-for-release-5.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@shhdgit: The label(s) cherry-pick-for-release-5.1 cannot be applied. These labels are supported: Hacktoberfest, challenge-program, ci-unstable, compatibility-breaker, high-performance, hptc, needs-cherry-pick-release-1.0, needs-cherry-pick-release-2.0, needs-cherry-pick-release-2.1, needs-cherry-pick-release-3.0, needs-cherry-pick-release-3.1, needs-cherry-pick-release-4.0, needs-cherry-pick-release-5.0, needs-cherry-pick-release-5.1, release-note, require-LGT1, wontfix.

In response to this:

/label cherry-pick-for-release-5.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. label Jun 18, 2021
@rleungx
Copy link
Member

rleungx commented Jun 18, 2021

Hi, seems it is duplicated with #3794.

@shhdgit
Copy link
Contributor Author

shhdgit commented Jun 18, 2021

Yes, how do I resolve the conflict in #3794, instead of opening a new pr?

@breezewish
Copy link
Member

@nolouch Please take a look about this PR, and please help close these two, thanks!

#3794
#3793

@HunDunDM
Copy link
Member

Yes, how do I resolve the conflict in #3794, instead of opening a new pr?

Due to some security issues, we are temporarily unable to do so, I will close the bot PR.

@HunDunDM HunDunDM added component/visualization Visualization. require-LGT1 Indicates that the PR requires an LGTM. type/cherry-pick-for-release-5.0 The PR belongs to release-5.0 cherry pick. and removed needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. labels Jun 22, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 22, 2021
@shhdgit
Copy link
Contributor Author

shhdgit commented Jun 22, 2021

Thank you so much.

@HunDunDM HunDunDM added this to the v5.0.3 milestone Jun 22, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 25, 2021
@nolouch
Copy link
Contributor

nolouch commented Jun 25, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9cd7f9f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 25, 2021
@purelind
Copy link
Contributor

/run-integration-tests

@nolouch
Copy link
Contributor

nolouch commented Jun 25, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/visualization Visualization. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-5.0 The PR belongs to release-5.0 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants