Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model: add Global field to IndexInfo #917

Merged
merged 4 commits into from
Jul 9, 2020
Merged

model: add Global field to IndexInfo #917

merged 4 commits into from
Jul 9, 2020

Conversation

ldeng-ustc
Copy link
Contributor

What problem does this PR solve?

pingcap/tidb#18402

What is changed and how it works?

Add Global field to IndexInfo.

Check List

  • Test in tidb.

Code changes

  • Has exported variable/fields change

Side effects

  • None.

Related changes

  • None.

@CLAassistant
Copy link

CLAassistant commented Jul 7, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 7, 2020 •
edited
Loading

Codecov Report

Merging #917 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #917      +/-   ##
==========================================
+ Coverage   78.36%   78.37%   +0.01%     
==========================================
  Files          40       40              
  Lines       14775    14783       +8     
==========================================
+ Hits        11578    11586       +8     
  Misses       2509     2509              
  Partials      688      688

kennytm
kennytm reviewed Jul 7, 2020
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot
Copy link
Contributor

@kennytm,Thanks for your review.

@kennytm kennytm added the status/LGT1 LGT1 label Jul 7, 2020
tangenta
tangenta approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@tangenta,Thanks for your review.

@ldeng-ustc ldeng-ustc mentioned this pull request Jul 9, 2020
Merged
@tiancaiamao tiancaiamao merged commit e38e79c into pingcap:master Jul 9, 2020
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@ldeng-ustc @tangenta @kennytm
model: add a Global field to IndexInfo (pingcap#917)
9a1835a 
Co-authored-by: tangenta <[email protected]>
Co-authored-by: kennytm <[email protected]>
@mjonss mjonss mentioned this pull request Feb 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@tangenta tangenta tangenta approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
status/LGT1 LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ldeng-ustc @CLAassistant @ti-srebot @kennytm @tangenta @tiancaiamao