Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: cherry pick #908 #909

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

breezewish
Copy link
Member

Signed-off-by: Breezewish [email protected]

What problem does this PR solve?

This PR cherry picks #908

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #909 into release-4.0 will increase coverage by 0.06%.
The diff coverage is 84.78%.

@@               Coverage Diff               @@
##           release-4.0     #909      +/-   ##
===============================================
+ Coverage        78.25%   78.31%   +0.06%     
===============================================
  Files               40       40              
  Lines            14710    14798      +88     
===============================================
+ Hits             11511    11589      +78     
- Misses            2519     2524       +5     
- Partials           680      685       +5     

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kennytm kennytm merged commit 3a18f1e into pingcap:release-4.0 Jun 23, 2020
@breezewish breezewish deleted the release-4.0-telemetry branch June 24, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants