Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: make the EvalType of TypeNull as ETInt #894

Closed
wants to merge 2 commits into from

Conversation

XuHuaiyu
Copy link
Contributor

What problem does this PR solve?

fix pingcap/tidb#16027

After pingcap/tidb#15512, TypeNull is defined as fixedLen. But the commit does not handle all the scenarios for TypeNull such https://github.com/pingcap/tidb/blob/master/expression/chunk_executor.go#L118.
We define the EvalType for TypeNull as EvalInt because the element length of TypeNull equals to TypeLonglong.

What is changed and how it works?

Define the EvalType of TypeNull as ETInt.

Check List

Tests

Test in tidb will cover this

Code changes

  • Has exported function/method change

Side effects

N/A

Related changes

  • Need to cherry-pick to the release branch

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #894 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
- Coverage   78.33%   78.30%   -0.03%     
==========================================
  Files          40       40              
  Lines       14745    14716      -29     
==========================================
- Hits        11550    11524      -26     
+ Misses       2508     2507       -1     
+ Partials      687      685       -2     

@XuHuaiyu
Copy link
Contributor Author

Wrong modification.

@XuHuaiyu XuHuaiyu closed this Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LEFT JOIN on a view results in "runtime error: slice bounds out of range [:264] with capacity 256"
1 participant