add hint nth_plan for plan test.
#893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #893 +/- ##
==========================================
+ Coverage 78.30% 78.31% +0.01%
==========================================
Files 40 40
Lines 14716 14723 +7
==========================================
+ Hits 11524 11531 +7
Misses 2507 2507
Partials 685 685 |
|
/rebuild |
kennytm
reviewed
Jun 9, 2020
| $$ = &ast.TableOptimizerHint{ | ||
| HintName: model.NewCIStr($1), | ||
| QBName: model.NewCIStr($3), | ||
| HintData: int64($4), |
There was a problem hiding this comment.
what happens with NTH_PLAN(18446744073709551615) ?
There was a problem hiding this comment.
@kennytm The planner in TiDB will check the number x given by the hint. An error will be given if x<-1 or x>100.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
to pingcap/tidb#17580
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes