Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: add auto_random_base table option #830

Merged
merged 2 commits into from
Apr 25, 2020

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Apr 24, 2020

What problem does this PR solve?

cherry-pick #823 & #828 to release-3.1
Add auto_random_base table option, so user can specified auto_rand_base when create table or alter table.

What is changed and how it works?

cherry-pick

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to update the documentation
  • Need to be included in the release note

@AilinKid AilinKid changed the title parser: add auto_rand_base table option parser: add auto_random_base table option Apr 24, 2020
@AilinKid AilinKid requested review from tangenta and bb7133 April 24, 2020 15:50
@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #830 into release-3.1 will increase coverage by 0.01%.
The diff coverage is 81.17%.

@@               Coverage Diff               @@
##           release-3.1     #830      +/-   ##
===============================================
+ Coverage        64.65%   64.67%   +0.01%     
===============================================
  Files               31       33       +2     
  Lines            11211    11489     +278     
===============================================
+ Hits              7248     7430     +182     
- Misses            3552     3635      +83     
- Partials           411      424      +13     

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Apr 24, 2020
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid AilinKid merged commit 994651e into pingcap:release-3.1 Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants