lexer: replace version comments with feature-ids mechanism (#777) #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* lexer: replace version comments with feature-ids mechanism * tests: retain the original version digit test * fix scanVersionDigits * add SpecialCommentsController to decide what comments can be parsed * only ignore comments with unsupported feature-id * remove debug log
Codecov Report
@@ Coverage Diff @@
## release-3.1 #829 +/- ##
===============================================
+ Coverage 64.65% 64.68% +0.03%
===============================================
Files 31 33 +2
Lines 11211 11483 +272
===============================================
+ Hits 7248 7428 +180
- Misses 3552 3631 +79
- Partials 411 424 +13 |
AilinKid
requested review from
tangenta,
tiancaiamao,
kennytm and
bb7133
and removed request for
tangenta and
tiancaiamao
|
duplicate with #819 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
cherry-pick featureIDs mechanism #777 to release-3.1
What is changed and how it works?
Check List
Tests
Related changes