Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model: add partition replica available info to support partition table in tiflash. #742

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

crazycs520
Copy link
Contributor

Signed-off-by: crazycs [email protected]

What problem does this PR solve?

related TiDB PR: pingcap/tidb#14735

What is changed and how it works?

Check List

Tests

  • No code

@crazycs520 crazycs520 requested a review from a team February 11, 2020 11:23
@ghost ghost requested review from tangenta and removed request for a team February 11, 2020 11:23
@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #742 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #742      +/-   ##
=========================================
- Coverage   77.63%   77.6%   -0.03%     
=========================================
  Files          40      40              
  Lines       14321   14326       +5     
=========================================
  Hits        11118   11118              
- Misses       2530    2535       +5     
  Partials      673     673

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Feb 11, 2020
Copy link
Contributor

@Deardrops Deardrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Deardrops Deardrops added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Feb 12, 2020
@kennytm kennytm merged commit 0829643 into pingcap:master Feb 12, 2020
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crazycs520 added a commit to crazycs520/parser that referenced this pull request Feb 13, 2020
crazycs520 added a commit that referenced this pull request Feb 13, 2020
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants