Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql: add foreign key error (#675) #690

Merged
merged 2 commits into from
Dec 19, 2019
Merged

mysql: add foreign key error (#675) #690

merged 2 commits into from
Dec 19, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

cherry-pick #675

@codecov
Copy link

codecov bot commented Dec 18, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-3.0@56b91da). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             release-3.0    #690   +/-   ##
=============================================
  Coverage               ?   64.6%           
=============================================
  Files                  ?      31           
  Lines                  ?   10870           
  Branches               ?       0           
=============================================
  Hits                   ?    7023           
  Misses                 ?    3438           
  Partials               ?     409

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56b91da...44901fd. Read the comment docs.

@crazycs520 crazycs520 mentioned this pull request Dec 19, 2019
Merged
wjhuang2016
wjhuang2016 reviewed Dec 19, 2019
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kennytm
kennytm approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT2 LGT2 label Dec 19, 2019
@kennytm kennytm merged commit 7df8c2c into pingcap:release-3.0 Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@kennytm kennytm kennytm approved these changes

Assignees
No one assigned
Labels
status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crazycs520 @kennytm @wjhuang2016