add error code from planner, expression and executor #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #650 +/- ##
=========================================
- Coverage 80.01% 80% -0.02%
=========================================
Files 32 32
Lines 12703 12696 -7
=========================================
- Hits 10164 10157 -7
Misses 1935 1935
Partials 604 604
Continue to review full report at Codecov.
|
tangenta
reviewed
Nov 26, 2019
jackysp
reviewed
Nov 26, 2019
mysql/errcode.go
Outdated
| ErrColumnStateCantNone = 8046 | ||
| ErrUnsupportedValueForVar = 8047 | ||
| ErrUnsupportedIsolationLevel = 8048 | ||
| ErrUnsupportedType = 8049 |
There was a problem hiding this comment.
It is better to start from 8100 to avoid some conflicts.
There was a problem hiding this comment.
@jackysp but it seems starting from 8100 has already been taken
ErrInvalidPluginID = 8101
ErrInvalidPluginManifest = 8102
ErrInvalidPluginName = 8103
ErrInvalidPluginVersion = 8104
ErrDuplicatePlugin = 8105
ErrInvalidPluginSysVarName = 8106
ErrRequireVersionCheckFail = 8107
So do we want to start from 8108 or 8200?
Co-Authored-By: Tanner <[email protected]>
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Associating internal error code for planner/core/errors.go, expression/errors.go and executor/errors.go to parser/mysql/errcode.go.
What is changed and how it works?
Adding more error code and set up the mapping.
Check List
Tests
Code changes
Side effects
Related changes