Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ast: add BinaryLiteral interface #370

Closed
wants to merge 1 commit into from

Conversation

imtbkcat
Copy link

@imtbkcat imtbkcat commented Jul 1, 2019

What problem does this PR solve?

#365 need to change the NewHexLiteral driver's return type to an new interface type BinaryLiteral.
There are also some change in TiDB side.

What is changed and how it works?

Change return type of NewHexLiteral and NewBitLiteral. Adding BinaryLiteral interface.

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

@imtbkcat
Copy link
Author

imtbkcat commented Jul 1, 2019

@kennytm PTAL

@imtbkcat imtbkcat closed this Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant