Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model: support add extra partition ID column #1010

Merged
merged 4 commits into from
Sep 12, 2020

Conversation

ldeng-ustc
Copy link
Contributor

What is changed and how it works?

Proposal: TiDB #18982

Double read in global index need an extra partition ID column. This PR add an unique Column ID to support it.

@tiancaiamao
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGT1 label Sep 8, 2020
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 LGT1 label Sep 12, 2020
@ti-srebot ti-srebot added the status/LGT2 LGT2 label Sep 12, 2020
@tiancaiamao tiancaiamao merged commit 04bc9d0 into pingcap:master Sep 12, 2020
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
define ExtraPidColID
add NewExtraPartitionIDColInfo to support create extra pid column
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants