Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Setup GitHub actions #115

Merged
merged 4 commits into from
Jan 22, 2024
Merged

CI: Setup GitHub actions #115

merged 4 commits into from
Jan 22, 2024

Conversation

dveeden
Copy link
Collaborator

@dveeden dveeden commented Nov 21, 2023 •
edited
Loading

Maybe we can do some testing in CI with GitHub actions?

@dveeden dveeden requested review from bb7133 and mjonss November 21, 2023 21:11
@dveeden dveeden requested a review from wuhuizuo December 7, 2023 08:10
@dveeden dveeden mentioned this pull request Dec 7, 2023
Open
@dveeden
Copy link
Collaborator Author

dveeden commented Dec 7, 2023

Note that Makefile has a # before ./mysql-tester -check-error so we only run the tests but without an actual TiDB instance. Maybe we can use TiDB Action from @Icemap for this. This can be done as part of this PR or later.

@dveeden
Copy link
Collaborator Author

dveeden commented Dec 7, 2023

Another thing we could do after this has been merged is to run golangci-lint. See also #121

@Defined2014
Copy link
Contributor

@bb7133 PTAL

bb7133
bb7133 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 merged commit aa83826 into pingcap:master Jan 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@mjonss mjonss mjonss approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

@wuhuizuo wuhuizuo Awaiting requested review from wuhuizuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dveeden @Defined2014 @bb7133 @mjonss