br: add compression type for br backup request #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
overvenus
reviewed
Jul 6, 2020
proto/backup.proto
Outdated
Comment on lines
120
to
126
| // algorithm used for compress sst file | ||
| enum CompressionType { | ||
| UNKNOWN = 0; | ||
| LZ4 = 1; | ||
| SNAPPY = 2; | ||
| ZSTD = 3; | ||
| } |
There was a problem hiding this comment.
Could you define the enum outside of BackupRequest?
This was referenced Jul 7, 2020
This was referenced Jul 15, 2020
glorv
added a commit
to glorv/kvproto
that referenced
this pull request
Jul 15, 2020
glorv
added a commit
to glorv/kvproto
that referenced
this pull request
Jul 15, 2020
overvenus
pushed a commit
that referenced
this pull request
Jul 15, 2020
glorv
added a commit
that referenced
this pull request
Jul 24, 2020
daimashusheng
pushed a commit
to daimashusheng/kvproto
that referenced
this pull request
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
CompressionTypefor br BackupRequest, so br can choose compress algorithm explicitly.