Skip to content
This repository was archived by the owner on Aug 21, 2023. It is now read-only.

fix auto consistency #123

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

resolveAutoConsistency should run after conf.ServerInfo is detected. Or it will be set to none.

What is changed and how it works?

Move resolveAutoConsistency to after detectServerInfo.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release note

@lichunzhu lichunzhu requested review from kennytm and overvenus July 14, 2020 08:56
@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #123 into master will increase coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   51.48%   51.59%   +0.10%     
==========================================
  Files          17       17              
  Lines        1853     1853              
==========================================
+ Hits          954      956       +2     
+ Misses        830      829       -1     
+ Partials       69       68       -1     

@lichunzhu lichunzhu merged commit 6d1ba10 into pingcap:master Jul 14, 2020
@lichunzhu lichunzhu deleted the fixResolveConsistency branch July 14, 2020 09:01
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
tisonkun pushed a commit to tisonkun/tidb that referenced this pull request Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants