Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dumpling code example format #8999

Merged
merged 4 commits into from
Jun 14, 2023
Merged

Conversation

ran-huang
Copy link
Contributor

What is changed, added or deleted? (Required)

Update dumpling code example format to improve usability.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ran-huang ran-huang added type/enhancement The issue or PR belongs to an enhancement. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. require-LGT1 Indicates that the PR requires an LGTM. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. area/dumpling Indicates that the Issue or PR belongs to the area of Dumpling. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Jun 17, 2022
@ran-huang ran-huang requested a review from TomShawn June 17, 2022 09:23
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 17, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2022
@ran-huang ran-huang added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Dec 29, 2022
@qiancai
Copy link
Collaborator

qiancai commented Feb 24, 2023

Removed the needs-cherry-pick-release-6.3 label because the v6.3 docs have been archived at https://docs-archive.pingcap.com/tidb/v6.3 and will no longer receive new updates.

@qiancai
Copy link
Collaborator

qiancai commented Apr 6, 2023

Removed the needs-cherry-pick-release-6.4 label because the v6.4 docs have been archived at https://docs-archive.pingcap.com/tidb/v6.4 and will no longer receive new updates.

@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Apr 23, 2023
@ran-huang ran-huang added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Jun 13, 2023
dumpling-overview.md Outdated Show resolved Hide resolved
dumpling-overview.md Outdated Show resolved Hide resolved
dumpling-overview.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-13 07:27:44.999334702 +0000 UTC m=+70661.413938781: ☑️ agreed by hfxsd.
  • 2023-06-13 07:47:09.509446928 +0000 UTC m=+71825.924051003: ☑️ agreed by Oreoxmt.

@ran-huang
Copy link
Contributor Author

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 14, 2023
@ti-chi-bot ti-chi-bot bot merged commit af3e53f into pingcap:master Jun 14, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #13863.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 14, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #13864.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #13865.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 14, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #13866.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 14, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #13867.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #13868.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 14, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Jun 14, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Jun 14, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Jun 14, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Jun 14, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Jun 14, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dumpling Indicates that the Issue or PR belongs to the area of Dumpling. lgtm needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants