Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system variable: add tidb_restricted_read_only #7670

Merged
merged 5 commits into from
Apr 26, 2022
Merged

system variable: add tidb_restricted_read_only #7670

merged 5 commits into from
Apr 26, 2022

Conversation

en-jin19
Copy link
Contributor

@en-jin19 en-jin19 commented Feb 22, 2022 •
edited
Loading

What is changed, added or deleted? (Required)

Added the description of following configurations:

  • RESTRICTED_REPLICA_WRITER_ADMIN in the "privilege-management.md"
  • tidb_restricted_read_only in the "system-variables.md"

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@en-jin19 en-jin19 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Feb 22, 2022
@en-jin19 en-jin19 requested review from ichn-hu and TomShawn February 22, 2022 09:48
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 22, 2022
ichn-hu
ichn-hu approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@ichn-hu ichn-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

en-jin19
en-jin19 commented Mar 4, 2022
View reviewed changes
en-jin19
en-jin19 commented Mar 4, 2022
View reviewed changes
en-jin19
en-jin19 commented Mar 4, 2022
View reviewed changes
en-jin19
en-jin19 commented Mar 4, 2022
View reviewed changes
@en-jin19 en-jin19 self-assigned this Mar 9, 2022
@en-jin19 en-jin19 added needs-cherry-pick-release-6.0 requires-followup This PR requires a follow-up task after being merged. labels Apr 1, 2022
en-jin19
en-jin19 commented Apr 14, 2022
View reviewed changes
en-jin19
en-jin19 commented Apr 14, 2022
View reviewed changes
en-jin19
en-jin19 commented Apr 14, 2022
View reviewed changes
en-jin19
en-jin19 commented Apr 14, 2022
View reviewed changes
TomShawn
TomShawn reviewed Apr 15, 2022
View reviewed changes
TomShawn
TomShawn reviewed Apr 15, 2022
View reviewed changes
system-variables.md Outdated
@@ -754,6 +754,21 @@ Constraint checking is always performed in place for pessimistic transactions (d
- `RESTRICTED_VARIABLES_ADMIN`: The ability to see and set sensitive variables in `SHOW [GLOBAL] VARIABLES` and `SET`.
- `RESTRICTED_USER_ADMIN`: The ability to prevent other users from making changes or dropping a user account.

### tidb_restricted_read_only <span class="version-mark">New in v5.2.0</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议按字母顺序放在下方

TomShawn
TomShawn reviewed Apr 15, 2022
View reviewed changes
TomShawn
TomShawn reviewed Apr 15, 2022
View reviewed changes
TomShawn
TomShawn reviewed Apr 15, 2022
View reviewed changes
TomShawn
TomShawn reviewed Apr 15, 2022
View reviewed changes
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 710f380

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2022
@en-jin19 en-jin19 removed the status/PTAL This PR is ready for reviewing. label Apr 26, 2022
@ti-chi-bot ti-chi-bot merged commit 0da64b8 into pingcap:master Apr 26, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 26, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8365.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 26, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8366.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 26, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8367.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 26, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8368.

@en-jin19 en-jin19 mentioned this pull request Apr 26, 2022
Merged
16 tasks
ti-chi-bot added a commit that referenced this pull request Apr 26, 2022
@ti-chi-bot
system variable: add tidb_restricted_read_only (#7670) (#8368)
633258c
ti-chi-bot added a commit that referenced this pull request Apr 26, 2022
@ti-chi-bot
system variable: add tidb_restricted_read_only (#7670) (#8365)
4e485f3
ti-chi-bot added a commit that referenced this pull request Apr 26, 2022
@ti-chi-bot
system variable: add tidb_restricted_read_only (#7670) (#8367)
545d65e
ti-chi-bot added a commit that referenced this pull request Apr 26, 2022
@ti-chi-bot
system variable: add tidb_restricted_read_only (#7670) (#8366)
16ddd47
This was referenced Apr 27, 2022
Merged
Merged
Merged
Merged
@morgo morgo mentioned this pull request Apr 28, 2022
Merged
16 tasks
This was referenced Apr 28, 2022
Merged
Merged
@hfxsd hfxsd mentioned this pull request Dec 21, 2023
Merged
17 tasks
This was referenced Dec 21, 2023
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichn-hu ichn-hu ichn-hu approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees

@en-jin19 en-jin19

Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. requires-followup This PR requires a follow-up task after being merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@en-jin19 @ti-chi-bot @ichn-hu @TomShawn