Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update migration-tidb-faq.md #5594

Merged
merged 4 commits into from
May 11, 2021
Merged

Update migration-tidb-faq.md #5594

merged 4 commits into from
May 11, 2021

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented May 10, 2021 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

update FAQ from oncall

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn May 10, 2021 07:08
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 10, 2021
@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels May 10, 2021
@Joyinqin Joyinqin marked this pull request as ready for review May 10, 2021 08:21
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2021
@Joyinqin
Copy link
Contributor Author

/cc @lance6716

@ti-chi-bot ti-chi-bot requested a review from lance6716 May 10, 2021 08:21
TomShawn
TomShawn reviewed May 10, 2021
View reviewed changes
TomShawn
TomShawn approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 11, 2021
@TomShawn
Copy link
Contributor

@lance6716 PTAL, thanks!

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 11, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cb16e61

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 11, 2021
@ti-chi-bot ti-chi-bot merged commit 0c3781d into pingcap:master May 11, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request May 11, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5594 to release-4.0
87de497 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request May 11, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5598

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request May 11, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5594 to release-5.0
c8f00c3 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request May 11, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5599

TomShawn pushed a commit that referenced this pull request May 11, 2021
@ti-srebot @Joyinqin
cherry pick #5594 to release-4.0 (#5598)
24100b5 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: JoyinQ <[email protected]>
TomShawn pushed a commit that referenced this pull request May 11, 2021
@ti-srebot @Joyinqin
cherry pick #5594 to release-5.0 (#5599)
6ba4f33 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: JoyinQ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Joyinqin @TomShawn @ti-chi-bot @ti-srebot @lance6716