Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv: change default value for pessimistic-txn.pipelined #5172

Merged
merged 2 commits into from
Apr 1, 2021
Merged

tikv: change default value for pessimistic-txn.pipelined #5172

merged 2 commits into from
Apr 1, 2021

Conversation

you06
Copy link
Contributor

@you06 you06 commented Mar 31, 2021

What is changed, added or deleted? (Required)

tikv/tikv#8499 changed the default value for pessimistic-txn.pipelined, this PR documents it.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

tikv/tikv#8499

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 31, 2021
@you06 you06 changed the title Change default value for pessimistic-txn.pipelined tikv: change default value for pessimistic-txn.pipelined Mar 31, 2021
@yikeke yikeke added the v5.0 This PR/issue applies to TiDB v5.0. label Mar 31, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Apr 1, 2021

/label needs-cherry-pick-5.0
/translation doing
/size small
/assign
/cc @gengliqi

@ti-chi-bot ti-chi-bot added the translation/doing This PR's assignee is translating this PR. label Apr 1, 2021
@ti-chi-bot ti-chi-bot requested a review from gengliqi April 1, 2021 02:36
@ti-chi-bot ti-chi-bot added size/small Changes of a small size. needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 1, 2021
MyonKeminta
MyonKeminta reviewed Apr 1, 2021
View reviewed changes
Copy link
Contributor

@MyonKeminta MyonKeminta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tikv-configuration-file.md Outdated
@@ -1294,4 +1294,4 @@ For pessimistic transaction usage, refer to [TiDB Pessimistic Transaction Mode](

This configuration item enables the pipelined process of adding the pessimistic lock. With this feature enabled, after detecting that data can be locked, TiKV immediately notifies TiDB to execute the subsequent requests and write the pessimistic lock asynchronously, which reduces most of the latency and significantly improves the performance of pessimistic transactions. But there is a still low probability that the asynchronous write of the pessimistic lock fails, which might cause the failure of pessimistic transaction commits.

The default value of `pipelined` is `false`.
The default value of `pipelined` is `true`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The default value of `pipelined` is `true`.
- Default value: `true`.

How about following the same format of other configurations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I make the description of pipelined the same format as others.

@you06
unify format
5422b5b 
Signed-off-by: you06 <[email protected]>
@ti-chi-bot ti-chi-bot removed the size/small Changes of a small size. label Apr 1, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Apr 1, 2021

/lgtm
/label require-LGT1

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 1, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Apr 1, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5422b5b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 1, 2021
@ti-chi-bot ti-chi-bot merged commit b618493 into pingcap:master Apr 1, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 1, 2021
@you06 @ti-srebot
cherry pick pingcap#5172 to release-5.0
173dbe5 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 1, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5183

ti-chi-bot pushed a commit that referenced this pull request Apr 1, 2021
@ti-srebot
tikv: change default value for pessimistic-txn.pipelined (#5172) (#5183)
6119750
@you06 you06 deleted the pipilined-default-true branch April 1, 2021 06:46
@TomShawn
Copy link
Contributor

TomShawn commented Apr 1, 2021

/remove-translation doing
/translation no-need

@ti-chi-bot ti-chi-bot added the translation/no-need No need to translate this PR. label Apr 1, 2021
@ti-chi-bot ti-chi-bot removed the translation/doing This PR's assignee is translating this PR. label Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyonKeminta MyonKeminta MyonKeminta left review comments

@gengliqi gengliqi Awaiting requested review from gengliqi

Assignees

@TomShawn TomShawn

Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@you06 @TomShawn @ti-chi-bot @ti-srebot @MyonKeminta @yikeke