Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update clustered indexes docs #5129

Merged
merged 13 commits into from
Mar 29, 2021
Merged

update clustered indexes docs #5129

merged 13 commits into from
Mar 29, 2021

Conversation

CharLotteiu
Copy link
Contributor

@CharLotteiu CharLotteiu commented Mar 26, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

Update the user documentation of clustered index feature introduced in v5.0-rc & v5.0.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 26, 2021
@CharLotteiu
Copy link
Contributor Author

/label need-cherry-pick-5.0
/label v5.0
/translation from-docs-cn
/status PTAL
/cc @tangenta @TomShawn

@ti-chi-bot ti-chi-bot requested review from tangenta and TomShawn March 26, 2021 07:07
@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. status/PTAL This PR is ready for reviewing. v5.0 This PR/issue applies to TiDB v5.0. labels Mar 26, 2021
@ti-chi-bot
Copy link
Member

@CharLotteiu: The label(s) need-cherry-pick-5.0 cannot be applied. These labels are supported: Hacktoberfest, contribution, first-time-contributor, requires-followup, good-first-issue, hacktoberfest-accepted, help-wanted, needs-cherry-pick-2.1, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-master, question, require-LGT1, require-LGT2, require-LGT3, special-week, v4.0, v5.0, for-future-release, requires-version-specific-changes, website.

In response to this:

/label need-cherry-pick-5.0
/label v5.0
/translation from-docs-cn
/status PTAL
/cc @tangenta @TomShawn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Mar 26, 2021
@CharLotteiu
Copy link
Contributor Author

/label needs-cherry-pick-5.0

tangenta
tangenta reviewed Mar 26, 2021
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
@Joyinqin Joyinqin mentioned this pull request Mar 26, 2021
Merged
11 tasks
TomShawn
TomShawn reviewed Mar 26, 2021
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
clustered-indexes.md Outdated Show resolved Hide resolved
clustered-indexes.md Outdated Show resolved Hide resolved
clustered-indexes.md Outdated Show resolved Hide resolved
clustered-indexes.md Outdated Show resolved Hide resolved
clustered-indexes.md Outdated Show resolved Hide resolved
clustered-indexes.md Outdated Show resolved Hide resolved
clustered-indexes.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor

/remove-status PTAL
/status require-change

@ti-chi-bot ti-chi-bot added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Mar 26, 2021
tangenta
tangenta reviewed Mar 27, 2021
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
tangenta
tangenta reviewed Mar 27, 2021
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
tangenta
tangenta reviewed Mar 27, 2021
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
@ti-srebot
Copy link
Contributor

@CharLotteiu, please update your pull request.

@CharLotteiu @TomShawn @tangenta
Apply suggestions from code review
1197314 
Co-authored-by: TomShawn <[email protected]>
Co-authored-by: tangenta <[email protected]>
CharLotteiu
CharLotteiu commented Mar 29, 2021
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
CharLotteiu
CharLotteiu commented Mar 29, 2021
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Mar 29, 2021
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Mar 29, 2021
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor

LGTM after addressing https://github.com/pingcap/docs/pull/5129/files#r602226514 and above comments.

@TomShawn
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 29, 2021
@tangenta
Copy link
Contributor

tangenta commented Mar 29, 2021 •
edited
Loading

Sorry, there is a patch PR for docs-cn pingcap/docs-cn#5864. Could you please also update those changes when it gets merged?

tangenta
tangenta reviewed Mar 29, 2021
View reviewed changes
clustered-indexes.md Outdated Show resolved Hide resolved
@tangenta
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 29, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 402511e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2021
@TomShawn
Copy link
Contributor

/remove-status require-change

@ti-chi-bot ti-chi-bot removed the status/require-change Needs the author to address comments. label Mar 29, 2021
@ti-chi-bot ti-chi-bot merged commit 343e916 into pingcap:master Mar 29, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 29, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#5129 to release-5.0
23560f6 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 29, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5154

ti-chi-bot pushed a commit that referenced this pull request Mar 29, 2021
@ti-srebot
update clustered indexes docs (#5129) (#5154)
a693f7e
@TomShawn TomShawn mentioned this pull request Apr 6, 2021
Merged
11 tasks
@CharLotteiu CharLotteiu deleted the clustered-index branch July 9, 2021 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@TomShawn TomShawn TomShawn left review comments

Assignees
No one assigned
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CharLotteiu @ti-chi-bot @TomShawn @ti-srebot @tangenta