Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: remove alter-primary-key configuration #5105

Merged
merged 9 commits into from
Mar 29, 2021
Merged

*: remove alter-primary-key configuration #5105

merged 9 commits into from
Mar 29, 2021

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Mar 25, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

The alter-primary-key config option is deprecated & removed in v5.0, this PR updates the related documentation.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2021
@Joyinqin
Copy link
Contributor Author

/translation from-docs-cn
/label v5.0
/label needs-cherry-pick-5.0

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0. needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Mar 25, 2021
@Joyinqin
Copy link
Contributor Author

/cc @tangenta @TomShawn

@ti-chi-bot ti-chi-bot requested review from tangenta and TomShawn March 25, 2021 10:27
@Joyinqin Joyinqin marked this pull request as ready for review March 25, 2021 10:27
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2021
TomShawn
TomShawn reviewed Mar 25, 2021
View reviewed changes
mysql-compatibility.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Mar 25, 2021
View reviewed changes
tidb-configuration-file.md Outdated

- Determines whether to add or remove the primary key constraint to or from a column.
- Default value: `false`
- With this default setting, adding or removing the primary key constraint is not supported. You can enable this feature by setting `alter-primary-key` to `true`. However, if a table already exists before the switch is on, and the data type of its primary key column is an integer, dropping the primary key from the column is not possible even if you set this configuration item to `true`.

> **Note:**
>
> This configuration item no longer takes effect. If you need to add or delete the primary key, use `NONCLUSTERED` instead. For more details about the primary key of the `CLUSTERED` type, refer to [clustered index](/clustered-indexes.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align https://github.com/pingcap/docs-cn/pull/5834/files#diff-0c6e827c2bde2f920447a23365ce5f4603fe7067d99ec1d1dfc3d22bb64c51e3R101 this line, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomShawn PTAL again thx!

TomShawn
TomShawn reviewed Mar 25, 2021
View reviewed changes
constraints.md Outdated Show resolved Hide resolved
@TomShawn TomShawn mentioned this pull request Mar 26, 2021
Merged
11 tasks
@TomShawn
Copy link
Contributor

rest
/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 26, 2021
@TomShawn
Copy link
Contributor

/label require-LGT1

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 26, 2021
@TomShawn
Copy link
Contributor

@tangenta PTAL, thanks!

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fc64a41

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2021
@ti-chi-bot ti-chi-bot merged commit 248ceed into pingcap:master Mar 29, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 29, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5105 to release-5.0
a8acf60 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 29, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5141

ti-chi-bot pushed a commit that referenced this pull request Mar 29, 2021
@ti-srebot
*: remove alter-primary-key configuration (#5105) (#5141)
1bffdfd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Joyinqin @TomShawn @ti-chi-bot @ti-srebot @tangenta