Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide the config global-kill #5075

Merged
merged 1 commit into from
Mar 26, 2021
Merged

hide the config global-kill #5075

merged 1 commit into from
Mar 26, 2021

Conversation

Joyinqin
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

The feature is not an experimental feature, thus we need to hide the config description.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 22, 2021
@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-5.0
/label v5.0

@ti-chi-bot ti-chi-bot added needs-cherry-pick-5.0 v5.0 This PR/issue applies to TiDB v5.0. labels Mar 22, 2021
@Joyinqin
Copy link
Contributor Author

/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Mar 22, 2021
@Joyinqin
Copy link
Contributor Author

/cc TomShawn

@ti-chi-bot ti-chi-bot requested a review from TomShawn March 22, 2021 08:57
@Joyinqin
Copy link
Contributor Author

/cc XuHuaiyu

@ti-chi-bot ti-chi-bot requested a review from XuHuaiyu March 22, 2021 09:14
@TomShawn
Copy link
Contributor

/uncc @TomShawn
/cc @qiancai

@ti-chi-bot ti-chi-bot requested review from qiancai and removed request for TomShawn March 24, 2021 07:24
@XuHuaiyu
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

@XuHuaiyu: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qiancai
Copy link
Collaborator

qiancai commented Mar 26, 2021

/lgtm

@ti-chi-bot
Copy link
Member

@qiancai: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

/lgtm
/label require-LGT1

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 26, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 26, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 162414d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 26, 2021
@ti-chi-bot ti-chi-bot merged commit a830283 into pingcap:master Mar 26, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 26, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5075 to release-5.0
426581d 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 26, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5126

ti-chi-bot pushed a commit that referenced this pull request Mar 26, 2021
@ti-srebot
hide the config global-kill (#5075) (#5126)
b0ae70d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@qiancai qiancai Awaiting requested review from qiancai

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Joyinqin @TomShawn @XuHuaiyu @ti-chi-bot @qiancai @ti-srebot