-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysql-compatibility: update ZERO_DATE docs #4436
Conversation
PTAL @9547 @lzmhhh123 Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@9547, @TomShawn, @lzmhhh123, PTAL. |
/merge |
@morgo Oops! This PR requires at least 2 LGTMs to merge. The current number of |
/label translation/done |
/unlabel translation/doing |
First-time contributors' checklist
What is changed, added or deleted? (Required)
The behavior of zero_date changed in master to be more mysql compatibility. This has not been backported.
There are some minor exceptions still, since DDL changes can still produce invalid dates (see: pingcap/tidb#21564 ). But I think these are minor, and it is worth updating the docs since the main workflow as described (INSERT/UPDATE) now matches MySQL.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
pingcap/tidb#20206
Do your changes match any of the following descriptions?