Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a new document about how to analyze slow queries #4035

Merged
merged 15 commits into from
Nov 20, 2020
Merged

add a new document about how to analyze slow queries #4035

merged 15 commits into from
Nov 20, 2020

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Oct 12, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Add a new document about how to analyze slow queries.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. size/large Changes of a large size. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 labels Oct 12, 2020
@TomShawn TomShawn requested review from qw4990 and yikeke October 12, 2020 12:06
@ti-srebot
Copy link
Contributor

@qw4990, @yikeke, PTAL.

2 similar comments
@ti-srebot
Copy link
Contributor

@qw4990, @yikeke, PTAL.

@ti-srebot
Copy link
Contributor

@qw4990, @yikeke, PTAL.

yikeke
yikeke reviewed Oct 22, 2020
View reviewed changes
yikeke
yikeke reviewed Oct 22, 2020
View reviewed changes
@ti-srebot
Copy link
Contributor

@yikeke, @qw4990, PTAL.

yikeke
yikeke reviewed Oct 26, 2020
View reviewed changes
@ti-srebot
Copy link
Contributor

@yikeke, @qw4990, PTAL.

2 similar comments
@ti-srebot
Copy link
Contributor

@yikeke, @qw4990, PTAL.

@ti-srebot
Copy link
Contributor

@yikeke, @qw4990, PTAL.

TomShawn
TomShawn commented Nov 5, 2020
View reviewed changes
yikeke
yikeke reviewed Nov 5, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-srebot
Copy link
Contributor

@yikeke, @qw4990, PTAL.

QueenyJin
QueenyJin reviewed Nov 8, 2020
View reviewed changes
analyze-slow-queries.md Outdated
1. Among many queries, identify which type of queries are slow.
2. Analyze why this type of queries are slow.

You can easily perform step 1 using the [slow query log](/identify-slow-queries.md) and the [statement summary table](/statement-summary-tables.md) features. It is recommended to use TiDB Dashboard, which integrates the two features and directly displays the slow queries in your browser.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if we point to the slow query page on TiDB Dashboard: https://docs.pingcap.com/tidb/dev/dashboard-slow-query

Copy link
Contributor Author

@TomShawn TomShawn Nov 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Link updated in 6f7fd5c.

TomShawn
TomShawn commented Nov 9, 2020
View reviewed changes
@ti-srebot
Copy link
Contributor

@yikeke, @queenypingcap, @qw4990, PTAL.

@ti-srebot
Copy link
Contributor

@yikeke, @queenypingcap, @qw4990, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@yikeke, @queenypingcap, @qw4990, PTAL.

qw4990
qw4990 reviewed Nov 20, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@qw4990, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 20, 2020
@TomShawn TomShawn merged commit b0c17f9 into pingcap:master Nov 20, 2020
@TomShawn TomShawn deleted the anyalyze-slow-queriess branch November 20, 2020 07:30
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Nov 20, 2020
@TomShawn @ti-srebot
cherry pick pingcap#4035 to release-4.0
bd665f8 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Nov 20, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4265

TomShawn added a commit that referenced this pull request Nov 20, 2020
@ti-srebot @TomShawn
cherry pick #4035 to release-4.0 (#4265)
1ac53f1 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: TomShawn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@QueenyJin QueenyJin QueenyJin left review comments

@yikeke yikeke yikeke approved these changes

Assignees
No one assigned
Labels
size/large Changes of a large size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomShawn @ti-srebot @qw4990 @QueenyJin @yikeke