-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basic features: convert to matrix #3960
Conversation
@SunRunAway, @zz-jason, @eurekaka, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@SunRunAway, @zz-jason, @eurekaka, PTAL. |
2 similar comments
@SunRunAway, @zz-jason, @eurekaka, PTAL. |
@SunRunAway, @zz-jason, @eurekaka, PTAL. |
@SunRunAway, @zz-jason, @eurekaka, @TomShawn, PTAL. |
@SunRunAway, @zz-jason, @eurekaka, @TomShawn, PTAL. |
@zz-jason AFAIU if something is planned for GA (but not currently), we should call it planned or experimental. This helps address this style nit @TomShawn made me aware of: https://developers.google.cn/style/future I think logically it makes sense too. When a feature is documented as if it is there, it can create a very frustrating user experience. For me this recently happened on: #3998 |
OK |
@SunRunAway, @zz-jason, @eurekaka, @TomShawn, @YiniXu9506, PTAL. |
1 similar comment
@SunRunAway, @zz-jason, @eurekaka, @TomShawn, @YiniXu9506, PTAL. |
@SunRunAway, @zz-jason, @eurekaka, @TomShawn, @YiniXu9506, PTAL. |
3 similar comments
@SunRunAway, @zz-jason, @eurekaka, @TomShawn, @YiniXu9506, PTAL. |
@SunRunAway, @zz-jason, @eurekaka, @TomShawn, @YiniXu9506, PTAL. |
@SunRunAway, @zz-jason, @eurekaka, @TomShawn, @YiniXu9506, PTAL. |
I'm going to close this as stale. I will reopen a new PR to replace it. |
What is changed, added or deleted? (Required)
This converts the basic features that TiDB supports to a matrix, similar to the one at https://www.postgresql.org/about/featurematrix/
Additional features can be added over time, the initial set is a little bit arbitrary.
It will likely cause version-specific issues because some of the linked files may not exist, so the links will either need to be removed or changed the exact version one.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?