Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic features: convert to matrix #3960

Closed
wants to merge 29 commits into from
Closed

basic features: convert to matrix #3960

wants to merge 29 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 24, 2020

What is changed, added or deleted? (Required)

This converts the basic features that TiDB supports to a matrix, similar to the one at https://www.postgresql.org/about/featurematrix/

Additional features can be added over time, the initial set is a little bit arbitrary.

It will likely cause version-specific issues because some of the linked files may not exist, so the links will either need to be removed or changed the exact version one.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@TomShawn TomShawn requested a review from zz-jason September 24, 2020 05:47
@TomShawn TomShawn added size/large Changes of a large size. status/PTAL This PR is ready for reviewing. translation/doing This PR's assignee is translating this PR. labels Sep 24, 2020
@TomShawn TomShawn self-assigned this Sep 24, 2020
basic-features.md Outdated Show resolved Hide resolved
basic-features.md Outdated Show resolved Hide resolved
basic-features.md Outdated Show resolved Hide resolved
basic-features.md Outdated Show resolved Hide resolved
@ti-srebot
Copy link
Contributor

@SunRunAway, @zz-jason, @eurekaka, PTAL.

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 30, 2020
@ti-srebot
Copy link
Contributor

@SunRunAway, @zz-jason, @eurekaka, PTAL.

2 similar comments
@ti-srebot
Copy link
Contributor

@SunRunAway, @zz-jason, @eurekaka, PTAL.

@ti-srebot
Copy link
Contributor

@SunRunAway, @zz-jason, @eurekaka, PTAL.

@ti-srebot
Copy link
Contributor

@SunRunAway, @zz-jason, @eurekaka, @TomShawn, PTAL.

@ti-srebot
Copy link
Contributor

@SunRunAway, @zz-jason, @eurekaka, @TomShawn, PTAL.

basic-features.md Show resolved Hide resolved
basic-features.md Outdated Show resolved Hide resolved
basic-features.md Show resolved Hide resolved
basic-features.md Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Oct 13, 2020

@zz-jason AFAIU if something is planned for GA (but not currently), we should call it planned or experimental. This helps address this style nit @TomShawn made me aware of:

https://developers.google.cn/style/future

I think logically it makes sense too. When a feature is documented as if it is there, it can create a very frustrating user experience. For me this recently happened on: #3998

@zz-jason
Copy link
Member

OK

@ti-srebot
Copy link
Contributor

1 similar comment
@ti-srebot
Copy link
Contributor

@ghost ghost added the requires-followup This PR requires a follow-up task after being merged. label Oct 19, 2020
@ti-srebot
Copy link
Contributor

3 similar comments
@ti-srebot
Copy link
Contributor

@ti-srebot
Copy link
Contributor

@ti-srebot
Copy link
Contributor

@morgo
Copy link
Contributor

morgo commented Aug 9, 2021

I'm going to close this as stale. I will reopen a new PR to replace it.

@morgo morgo closed this Aug 9, 2021
@morgo morgo mentioned this pull request Aug 9, 2021
11 tasks
@TomShawn TomShawn removed translation/doing This PR's assignee is translating this PR. requires-followup This PR requires a follow-up task after being merged. size/large Changes of a large size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. needs-cherry-pick-release-4.0 labels Aug 10, 2021
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. missing-translation-status This PR does not have translation status info. labels Aug 10, 2021
@TomShawn TomShawn removed their assignment Aug 10, 2021
@TomShawn TomShawn removed the request for review from scsldb August 10, 2021 01:55
@TomShawn TomShawn removed status/LGT1 Indicates that a PR has LGTM 1. missing-translation-status This PR does not have translation status info. labels Aug 10, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants