Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explain: add index merge #3924

Merged
merged 2 commits into from Sep 17, 2020
Merged

explain: add index merge #3924

merged 2 commits into from Sep 17, 2020

Conversation

ghost
Copy link

@ghost ghost commented Sep 17, 2020

What is changed, added or deleted? (Required)

This is a followup PR to #3858 - but they can be reviewed independently, and merge out of order.

This PR does not add this page to the TOC. I will only do that once all PRs are merged (this is one ~3-4 followup PRs).

The content here is taken directly from query-execution-plan#indexmerge-example. I have not made any changes, it LGTM already.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ghost ghost added needs-cherry-pick-4.0 status/PTAL This PR is ready for reviewing. labels Sep 17, 2020
@TomShawn TomShawn assigned TomShawn and Joyinqin and unassigned TomShawn Sep 17, 2020
@TomShawn TomShawn added size/small Changes of a small size. translation/doing This PR's assignee is translating this PR. labels Sep 17, 2020
TomShawn
TomShawn approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 17, 2020
@TomShawn TomShawn merged commit fa19918 into pingcap:master Sep 17, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Sep 17, 2020
@ti-srebot
cherry pick pingcap#3924 to release-4.0
fd82525 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Sep 17, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3925

TomShawn pushed a commit that referenced this pull request Sep 17, 2020
@ti-srebot
cherry pick #3924 to release-4.0 (#3925)
dd50c51 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: Null not nil <[email protected]>
@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Sep 23, 2020
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR's assignee is translating this PR. label Sep 23, 2020
@Joyinqin Joyinqin mentioned this pull request Sep 23, 2020
Merged
9 tasks
@ti-srebot ti-srebot mentioned this pull request Oct 12, 2020
Merged
9 tasks
@Joyinqin Joyinqin mentioned this pull request Oct 26, 2020
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Joyinqin Joyinqin

Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-srebot @Joyinqin @TomShawn