Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: add use constraint with TiCDC and Drainer #3839

Merged
merged 7 commits into from
Sep 8, 2020
Merged

br: add use constraint with TiCDC and Drainer #3839

merged 7 commits into from
Sep 8, 2020

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Sep 6, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Add use constraint with TiCDC and Drainer.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@Joyinqin
Copy link
Contributor Author

Joyinqin commented Sep 6, 2020

/label needs-cherry-pick-3.1, needs-cherry-pick-4.0, size/small, version-specific-changes-required

@ti-srebot ti-srebot added needs-cherry-pick-3.1 size/small Changes of a small size. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. labels Sep 6, 2020
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Sep 6, 2020

/label translation/from-docs-cn

@ti-srebot ti-srebot added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Sep 6, 2020
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Sep 6, 2020

/cc TomShawn, YuJuncen

TomShawn
TomShawn reviewed Sep 7, 2020
View reviewed changes
TomShawn
TomShawn approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 8, 2020
@YuJuncen
Copy link
Contributor

YuJuncen commented Sep 8, 2020

LGTM

@ti-srebot
Copy link
Contributor

@YuJuncen,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack).

@TomShawn TomShawn merged commit 04715f3 into pingcap:master Sep 8, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Sep 8, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#3839 to release-3.1
4067d3d 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Sep 8, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #3848

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Sep 8, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#3839 to release-4.0
0c26902 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Sep 8, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3849

ti-srebot added a commit that referenced this pull request Sep 8, 2020
@ti-srebot
br: add use constraint with TiCDC and Drainer (#3839) (#3849)
4604a0b 
Signed-off-by: ti-srebot <[email protected]>
ti-srebot added a commit that referenced this pull request Sep 8, 2020
@ti-srebot
br: add use constraint with TiCDC and Drainer (#3839) (#3848)
457276d 
Signed-off-by: ti-srebot <[email protected]>
@Joyinqin Joyinqin deleted the br-faq branch September 8, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@YuJuncen YuJuncen Awaiting requested review from YuJuncen

Assignees
No one assigned
Labels
requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Joyinqin @YuJuncen @ti-srebot @TomShawn