Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Titan documents #3811

Merged
merged 11 commits into from
Sep 17, 2020
Merged

Add Titan documents #3811

merged 11 commits into from
Sep 17, 2020

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Sep 3, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Add two Titan documents.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. size/large Changes of a large size. needs-cherry-pick-4.0 labels Sep 3, 2020
@TomShawn TomShawn marked this pull request as ready for review September 7, 2020 06:59
Connor1996
Connor1996 approved these changes Sep 7, 2020
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@Connor1996,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack).

lilin90
lilin90 reviewed Sep 15, 2020
View reviewed changes
@lilin90 lilin90 added the status/require-change Needs the author to address comments. label Sep 15, 2020
lilin90
lilin90 reviewed Sep 16, 2020
View reviewed changes
lilin90
lilin90 approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 17, 2020
@lilin90 lilin90 removed the status/require-change Needs the author to address comments. label Sep 17, 2020
@lilin90 lilin90 merged commit 4a18cbc into pingcap:master Sep 17, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Sep 17, 2020
@TomShawn @ti-srebot
cherry pick pingcap#3811 to release-4.0
4c099e5 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Sep 17, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3931

ti-srebot added a commit that referenced this pull request Sep 17, 2020
@ti-srebot
Add Titan documents (#3811) (#3931)
b48918a 
Signed-off-by: ti-srebot <[email protected]>
@TomShawn TomShawn deleted the titan-documents branch September 17, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Connor1996 Connor1996 Connor1996 approved these changes

@lilin90 lilin90 lilin90 approved these changes

Assignees
No one assigned
Labels
size/large Changes of a large size. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomShawn @ti-srebot @Connor1996 @lilin90