Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scripts to verify anchors in CI (#3128) #3129

Merged
merged 6 commits into from
Jul 3, 2020
Merged

Add scripts to verify anchors in CI (#3128) #3129

merged 6 commits into from
Jul 3, 2020

Conversation

yikeke
Copy link
Contributor

@yikeke yikeke commented Jul 3, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

cherry-pick from #3128

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@yikeke yikeke changed the base branch from master to release-3.1 July 3, 2020 02:56
@yikeke yikeke marked this pull request as draft July 3, 2020 02:56
@yikeke yikeke added the type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR. label Jul 3, 2020
@github-actions github-actions bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jul 3, 2020
@yikeke yikeke removed the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label Jul 3, 2020
@yikeke yikeke marked this pull request as ready for review July 3, 2020 04:35
yikeke
yikeke commented Jul 3, 2020
View reviewed changes
tiflash/maintain-tiflash.md Outdated Show resolved Hide resolved
tiflash/maintain-tiflash.md Outdated Show resolved Hide resolved
@yikeke yikeke requested a review from lilin90 July 3, 2020 04:45
lilin90
lilin90 approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 3, 2020
@ti-srebot
Copy link
Contributor

@lilin90,Thanks for your review.

ti-srebot
ti-srebot approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@ti-srebot ti-srebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor Author

yikeke commented Jul 3, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 3, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@yikeke
Copy link
Contributor Author

yikeke commented Jul 3, 2020

/merge

@yikeke yikeke merged commit b3b4f65 into release-3.1 Jul 3, 2020
@yikeke yikeke deleted the add-anchor-check-3.1 branch July 3, 2020 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yikeke @ti-srebot @lilin90