Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

en: Add operator version requirement for telemetry config #3095

Merged
merged 2 commits into from
Jul 1, 2020
Merged

en: Add operator version requirement for telemetry config #3095

merged 2 commits into from
Jul 1, 2020

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Jul 1, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Add a note about TiDB Operator v1.1.2 requirement

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@github-actions github-actions bot requested a review from TomShawn July 1, 2020 04:56
@github-actions github-actions bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jul 1, 2020
@TomShawn TomShawn requested a review from DanielZhangQD July 1, 2020 04:58
@TomShawn TomShawn added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jul 1, 2020
DanielZhangQD
DanielZhangQD approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TomShawn
TomShawn reviewed Jul 1, 2020
View reviewed changes
telemetry.md Outdated Show resolved Hide resolved
telemetry.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor

TomShawn commented Jul 1, 2020

LGTM

@TomShawn
Copy link
Contributor

TomShawn commented Jul 1, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 1, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit d5a8429 into master Jul 1, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 1, 2020
@breezewish @ti-srebot
cherry pick pingcap#3095 to release-4.0
ee80181 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jul 1, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3096

@breezewish breezewish deleted the telemetry-operator-note branch July 1, 2020 05:33
TomShawn added a commit that referenced this pull request Jul 3, 2020
@ti-srebot @breezewish @TomShawn
cherry pick #3095 to release-4.0 (#3096)
0b0eaec 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: Wenxuan <[email protected]>
Co-authored-by: TomShawn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@breezewish @TomShawn @ti-srebot @DanielZhangQD