Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb-lightning,br: replaced black-white-list by table-filter #3065

Merged
merged 5 commits into from
Jul 3, 2020

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Jun 29, 2020

What is changed, added or deleted? (Required)

This PR documented the "table filter" feature shared by all new TiDB ecosystem tools, superseding the old "black-white-list" feature. The documentation is heavily copied from https://github.com/pingcap/tidb-tools/blob/master/pkg/table-filter/README.md.

The feature is / will be available in

  • Lightning (v4.0.2, v3.1.3, v3.0.17)
  • BR (v4.0.0-rc, v3.1.0-rc)
  • Dumpling
  • CDC (v4.0.2)
  • (DM may also switch to this in the future.)

The Lightning docs have been revised for this. The existing "black-white-list" page has been redirected to the shared reference. ("black-white-list" still works but are no longer recommended. Therefore we don't bother to rename these into "block-allow-list")

The BR docs have been expanded to describe -f.

Dumpling is untouched, but whoever translating pingcap/docs-cn#3541 should point the link in --filter to this new document rather than the README.md.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions) (only BR and Lightning)
  • v3.0 (TiDB 3.0 versions) (only Lightning)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@kennytm kennytm added the status/PTAL This PR is ready for reviewing. label Jun 29, 2020
@github-actions github-actions bot requested a review from kissmydb June 29, 2020 19:56
@kennytm kennytm requested review from ran-huang and removed request for kissmydb June 29, 2020 19:56
@github-actions github-actions bot added the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label Jun 29, 2020
@TomShawn TomShawn removed their request for review June 30, 2020 02:04
@TomShawn TomShawn added the size/large Changes of a large size. label Jun 30, 2020
table-filter.md Outdated Show resolved Hide resolved
br/backup-and-restore-tool.md Outdated Show resolved Hide resolved
br/backup-and-restore-tool.md Outdated Show resolved Hide resolved
table-filter.md Outdated Show resolved Hide resolved
table-filter.md Outdated Show resolved Hide resolved
table-filter.md Outdated Show resolved Hide resolved
table-filter.md Outdated Show resolved Hide resolved
table-filter.md Show resolved Hide resolved
table-filter.md Outdated Show resolved Hide resolved
table-filter.md Outdated Show resolved Hide resolved
@ran-huang
Copy link
Contributor

@WangXiangUSTC PTAL. Thanks~

@@ -151,7 +151,7 @@
+ [Configure](/tidb-lightning/tidb-lightning-configuration.md)
+ Key Features
+ [Checkpoints](/tidb-lightning/tidb-lightning-checkpoints.md)
+ [Table Filter](/tidb-lightning/tidb-lightning-table-filter.md)
+ [Table Filter](/table-filter.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe remove this since other tools also have table filter feature

Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT1 Indicates that a PR has LGTM 1. and removed status/PTAL This PR is ready for reviewing. labels Jul 2, 2020
@ti-srebot
Copy link
Contributor

@ran-huang,Thanks for your review.

@ran-huang ran-huang merged commit 68375a7 into master Jul 3, 2020
@ran-huang ran-huang deleted the kennytm/filter branch July 3, 2020 07:20
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 3, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #3138

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 3, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #3139

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 3, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3140

ran-huang added a commit that referenced this pull request Jul 3, 2020
…3140)

* cherry pick #3065 to release-4.0

Signed-off-by: ti-srebot <[email protected]>

* update aliases

* fix aliases

Co-authored-by: kennytm <[email protected]>
Co-authored-by: Ran <[email protected]>
@yikeke yikeke added translation/doing This PR's assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jul 6, 2020
@yikeke yikeke self-assigned this Jul 6, 2020
@ran-huang ran-huang assigned ran-huang and unassigned yikeke Jul 7, 2020
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/large Changes of a large size. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants