Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiflash: reformat TiFlash config file #20380

Merged
merged 4 commits into from
Feb 27, 2025

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Feb 27, 2025

What is changed, added or deleted? (Required)

tiflash: reformat TiFlash config file
ref: #19524

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added type/enhancement The issue or PR belongs to an enhancement. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Feb 27, 2025
@Oreoxmt Oreoxmt self-assigned this Feb 27, 2025
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Feb 27, 2025

/cc @qiancai

@ti-chi-bot ti-chi-bot bot requested a review from qiancai February 27, 2025 02:33
@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 27, 2025
github-actions bot pushed a commit to Oreoxmt/pingcap-docsite-preview that referenced this pull request Feb 27, 2025
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Oreoxmt Oreoxmt requested a review from qiancai February 27, 2025 03:25
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Copy link

ti-chi-bot bot commented Feb 27, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-27 04:47:20.773167256 +0000 UTC m=+503988.726325514: ☑️ agreed by qiancai.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 27, 2025
@Oreoxmt Oreoxmt force-pushed the reformat-config-tiflash branch from e14b75a to 2a4f2da Compare February 27, 2025 05:32
@Oreoxmt Oreoxmt added the lgtm label Feb 27, 2025
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Feb 27, 2025

/approve

Copy link

ti-chi-bot bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 27, 2025
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Feb 27, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2025
@ti-chi-bot ti-chi-bot bot merged commit 2c1a237 into pingcap:master Feb 27, 2025
9 checks passed
@Oreoxmt Oreoxmt deleted the reformat-config-tiflash branch February 27, 2025 05:38
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20391.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants