Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud: update a few steps for connection and migration #20370

Merged
merged 10 commits into from
Mar 4, 2025

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Feb 25, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Feb 25, 2025
@qiancai qiancai self-assigned this Feb 25, 2025
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 25, 2025
@qiancai qiancai added type/enhancement The issue or PR belongs to an enhancement. translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 25, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Feb 25, 2025
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 26, 2025
Copy link
Member

@shiyuhang0 shiyuhang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve for the serverless part

Copy link

ti-chi-bot bot commented Feb 26, 2025

@shiyuhang0: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

approve for the serverless part

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Feb 26, 2025

@xuanyu66: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiancai qiancai requested a review from D3Hunter February 26, 2025 06:17
Copy link

ti-chi-bot bot commented Feb 28, 2025

@zhangyangyu: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 28, 2025
@dveeden
Copy link
Contributor

dveeden commented Feb 28, 2025

Might be good to sync the lycheeignore file from master to fix the linkChecker CI error

git fetch --all
git restore -s master .lycheeignore
diff --git a/.lycheeignore b/.lycheeignore
index ce919d2c7..9c1e0c7f4 100644
--- a/.lycheeignore
+++ b/.lycheeignore
@@ -15,4 +15,19 @@ http://\{grafana-ip\}:3000
 http://\{pd-ip\}:2379/dashboard
 http://localhost:\d+/
 https://github\.com/\$user/(docs|docs-cn)
-https://linux.die.net/man.*
+https://linux\.die\.net/man.*
+https://dev\.mysql\.com/doc/.+/5.7/en/.*
+https://dev\.mysql\.com/doc/.+/8\.0/en/.*
+https://dev\.mysql\.com/doc/.+/8\.4/en/.*
+https://dev\.mysql\.com/doc/[a-z\-]+/en/.*
+https://dev\.mysql\.com/doc/relnotes/[a-z\-]+/en/.*
+https://dev\.mysql\.com/doc/dev/mysql-server/.*
+https://dev\.mysql\.com/downloads/.*
+https://bugs\.mysql\.com/bug\.php.*
+https://www\.mysql\.com/products/.*
+https://platform\.openai\.com/docs/.*
+https://openai\.com/.*
+https://jwt\.io/
+https://typeorm\.io/.*
+https://dash\.cloudflare\.com/.*
+https://centminmod\.com/mydumper\.html

@ti-chi-bot ti-chi-bot bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 28, 2025
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 28, 2025
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 4, 2025
Copy link

ti-chi-bot bot commented Mar 4, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-28 07:08:38.315938969 +0000 UTC m=+598866.269097235: ☑️ agreed by dveeden.
  • 2025-03-04 08:32:07.364512941 +0000 UTC m=+344040.493432684: ☑️ agreed by lilin90.

@qiancai
Copy link
Collaborator Author

qiancai commented Mar 4, 2025

/approve

Copy link

ti-chi-bot bot commented Mar 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 4, 2025
@ti-chi-bot ti-chi-bot bot merged commit 8a2fe1d into pingcap:release-8.1 Mar 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tidb-cloud This PR relates to the area of TiDB Cloud. lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants