Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: update wording for accuracy #20233

Merged
merged 2 commits into from
Feb 11, 2025
Merged

*: update wording for accuracy #20233

merged 2 commits into from
Feb 11, 2025

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Feb 11, 2025 •
edited
Loading

What is changed, added or deleted? (Required)

  • Changes "resolve" to "parse" to match context
  • Changes "clustered indexes" to "clustered index tables" for accuracy

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 added the translation/doing This PR's assignee is translating this PR. label Feb 11, 2025
@lilin90 lilin90 self-assigned this Feb 11, 2025
@lilin90 lilin90 added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. labels Feb 11, 2025
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 11, 2025
@lilin90 lilin90 requested a review from hfxsd February 11, 2025 09:15
@lilin90 lilin90 mentioned this pull request Feb 11, 2025
Merged
15 tasks
@ti-chi-bot ti-chi-bot bot added area/develop This PR relates to the area of TiDB App development. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2025
@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Feb 11, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 11, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-11 09:45:56.975231647 +0000 UTC m=+349799.371453704: ☑️ agreed by hfxsd.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 11, 2025

@hfxsd: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 11, 2025

@hfxsd: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lilin90 lilin90 added the lgtm label Feb 11, 2025
@lilin90
Copy link
Member Author

lilin90 commented Feb 11, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 11, 2025
@ti-chi-bot ti-chi-bot bot merged commit cb583d8 into pingcap:master Feb 11, 2025
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20234.

This was referenced Feb 11, 2025
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #20235.

This was referenced Feb 11, 2025
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #20236.

This was referenced Feb 11, 2025
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #20237.

This was referenced Feb 11, 2025
Merged
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #20238.

This was referenced Feb 11, 2025
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #20239.

This was referenced Feb 11, 2025
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #20240.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 11, 2025
Merged
15 tasks
@lilin90 lilin90 deleted the update-wording branch February 12, 2025 06:50
ti-chi-bot bot pushed a commit that referenced this pull request Feb 12, 2025
@ti-chi-bot
*: update wording for accuracy (#20233) (#20234)
317a71c
ti-chi-bot bot pushed a commit that referenced this pull request Feb 12, 2025
@ti-chi-bot
*: update wording for accuracy (#20233) (#20237)
64a107d
ti-chi-bot bot pushed a commit that referenced this pull request Feb 12, 2025
@ti-chi-bot
*: update wording for accuracy (#20233) (#20239)
932a775
ti-chi-bot bot pushed a commit that referenced this pull request Feb 12, 2025
@ti-chi-bot
*: update wording for accuracy (#20233) (#20236)
19c0d06
ti-chi-bot bot pushed a commit that referenced this pull request Feb 12, 2025
@ti-chi-bot
*: update wording for accuracy (#20233) (#20238)
2032638
ti-chi-bot bot pushed a commit that referenced this pull request Feb 12, 2025
@ti-chi-bot
*: update wording for accuracy (#20233) (#20240)
f0c724e
ti-chi-bot bot pushed a commit that referenced this pull request Feb 12, 2025
@ti-chi-bot
*: update wording for accuracy (#20233) (#20235)
c5edf78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

Assignees

@lilin90 lilin90

Labels
approved area/develop This PR relates to the area of TiDB App development. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilin90 @ti-chi-bot @hfxsd