Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TiDB auto increment MySQL-compatible behavior clarification #20152

Conversation

alastori
Copy link
Contributor

@alastori alastori commented Feb 3, 2025

What is changed, added or deleted? (Required)

Improved the MySQL compatibility mode section in auto-increment.md by:

  1. Providing a clearer introduction that immediately states the purpose and benefits
  2. Adding practical examples showing behavior differences between AUTO_ID_CACHE 1 and default mode
  3. Explaining when and why gaps might occur in the sequence
  4. Restructuring the version-specific notes for better readability
  5. Adding information about v8.1.0 changes regarding forceRebase operation

These changes make it easier for users to:

  • Understand the practical differences between MySQL compatibility mode and default mode
  • See concrete examples of ID allocation behavior in different scenarios
  • Understand the performance implications across different TiDB versions

Which TiDB version(s) do your changes apply to? (Required)

Since this change includes information about behavior changes across multiple versions (v6.4.0 and v8.1.0) and documents current functionality, it should be applied to:

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

N/A

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

- Update GitHub repository links from tidb-tools to tiflow

- Add TiUP installation method for v9.0.0+

- Update Docker image references

- Add version-specific installation instructions

- Update download-ecosystem-tools.md with new package information
Update Docker image for sync-diff-inspector

The previous `docker pull pingcap/tiflow:latest` command was incorrect. After confirming with Flare Zuo (R&D Group - Engineering Productivity - Efficiency & Ops team), we should use `docker pull pingcap/sync-diff-inspector:latest` to align with TiCDC and DM, ensuring consistency across TiFlow-managed images.

This update reflects the correct image name for better usability.
This commit improves the documentation by: Adding clearer introduction and benefits, including practical examples of ID allocation, adding comparison between AUTO_ID_CACHE modes, restructuring version-specific notes, and adding v8.1.0 forceRebase information
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 3, 2025
@alastori
Copy link
Contributor Author

alastori commented Feb 3, 2025

/cc @Frank945946

Copy link

ti-chi-bot bot commented Feb 3, 2025

@alastori: GitHub didn't allow me to request PR reviews from the following users: frank945946.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Frank945946

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lilin90 lilin90 added type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR's assignee is translating this PR. labels Feb 6, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Feb 6, 2025
@lilin90 lilin90 self-assigned this Feb 6, 2025
@lilin90 lilin90 added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. labels Feb 6, 2025
@lilin90 lilin90 requested review from hfxsd and lilin90 February 11, 2025 08:41
Copy link

ti-chi-bot bot commented Feb 11, 2025

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 11, 2025
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 13, 2025
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 13, 2025
Copy link

ti-chi-bot bot commented Feb 13, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-11 13:28:39.032126436 +0000 UTC m=+363161.428348491: ☑️ agreed by dveeden.
  • 2025-02-13 10:15:03.715256706 +0000 UTC m=+524346.111478765: ☑️ agreed by lilin90.

@lilin90
Copy link
Member

lilin90 commented Feb 13, 2025

/approve

Copy link

ti-chi-bot bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 13, 2025
@ti-chi-bot ti-chi-bot bot merged commit d806807 into pingcap:master Feb 13, 2025
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #20283.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #20284.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20285.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #20286.

@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants