-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: update TOC and title wording for on-boarding docs #19353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Aolin <[email protected]>
dashboard/dashboard-ops-deploy.md
Outdated
@@ -14,7 +14,7 @@ The TiDB Dashboard UI is built into the PD component for v4.0 or higher versions | |||
|
|||
See the following documents to learn how to deploy a standard TiDB cluster: | |||
|
|||
+ [Quick Start Guide for the TiDB Database Platform](/quick-start-with-tidb.md) | |||
+ [Quick Start with TiDB Self-Managed Using TiUP Playground](/quick-start-with-tidb.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using -> using
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use the Chicago Style for titles, so let's keep it as "Using".
@lilin90 A few small wording and URL comments, please see inline. |
[LGTM Timeline notifier]Timeline:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What is changed, added or deleted? (Required)
TOC.md
and titles of several docsNew TOC preview: https://pingcap-docsite-preview-git-preview-pi-6cb116-oreoxmts-projects.vercel.app/tidb/dev/
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?