Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reference/tools: add "-tidb-password" cli flag in tidb-lightning config #1711

Merged
merged 2 commits into from
Feb 4, 2020
Merged

reference/tools: add "-tidb-password" cli flag in tidb-lightning config #1711

merged 2 commits into from
Feb 4, 2020

Conversation

jlerche
Copy link

@jlerche jlerche commented Dec 17, 2019 •
edited
Loading

What is changed, added or deleted?

Adds reference to -tidb-password command line flag for tidb-lightning in the config section

What is the related PR or file link(s)?

pingcap/tidb-lightning#253

Which version does your change affect?

dev, 3.0, 3.1

@jlerche jlerche requested a review from kennytm December 17, 2019 17:52
@jlerche jlerche mentioned this pull request Dec 17, 2019
Merged
@lilin90 lilin90 added translation/doing This PR's assignee is translating this PR. size/small Changes of a small size. labels Dec 18, 2019
kennytm
kennytm reviewed Dec 18, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 changed the title Adds -tidb-password cli flag in tidb-lightning config reference/tools: add "-tidb-password" cli flag in tidb-lightning config Dec 26, 2019
lilin90
lilin90 approved these changes Dec 26, 2019
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lilin90
lilin90 reviewed Dec 26, 2019
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlerche I confirmed with @kennytm that this change also applies to v3.1 and v3.0. Would you please also help update the other two files in this PR? Thanks!

@anotherrachel anotherrachel added the requires-followup This PR requires a follow-up task after being merged. label Jan 8, 2020
@anotherrachel anotherrachel mentioned this pull request Jan 8, 2020
Merged
@anotherrachel anotherrachel added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jan 8, 2020
@jlerche jlerche force-pushed the tidb-lightning_add_password_cli_arg_flag branch from df29801 to a114ce8 Compare February 4, 2020 17:43
@jlerche
Copy link
Author

jlerche commented Feb 4, 2020

@lilin90 I just updated v3.0 and v3.1

@jlerche jlerche requested review from lilin90 and kennytm February 4, 2020 17:50
@jlerche jlerche merged commit fe2d9c3 into pingcap:master Feb 4, 2020
@jlerche jlerche deleted the tidb-lightning_add_password_cli_arg_flag branch February 4, 2020 18:02
@anotherrachel anotherrachel removed the requires-followup This PR requires a follow-up task after being merged. label Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm approved these changes

@lilin90 lilin90 Awaiting requested review from lilin90

Assignees

@anotherrachel anotherrachel

Labels
size/small Changes of a small size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jlerche @kennytm @lilin90 @anotherrachel