Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv: document periodic full compaction. #15630

Merged

Conversation

afeinberg
Copy link
Contributor

@afeinberg afeinberg commented Dec 8, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Dec 8, 2023
@CLAassistant
Copy link

CLAassistant commented Dec 8, 2023

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 8, 2023
@afeinberg
Copy link
Contributor Author

/cc @tonyxuqqi @Connor1996

@ti-chi-bot ti-chi-bot bot requested review from Connor1996 and tonyxuqqi December 8, 2023 05:58
Signed-off-by: Alex Feinberg <[email protected]>
@afeinberg afeinberg requested a review from Connor1996 December 8, 2023 06:17
Signed-off-by: Alex Feinberg <[email protected]>
Copy link

ti-chi-bot bot commented Dec 8, 2023

@tonyxuqqi: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Alex Feinberg <[email protected]>
@afeinberg
Copy link
Contributor Author

/assign @tonyxuqqi

@Oreoxmt Oreoxmt self-requested a review December 8, 2023 06:46
@Oreoxmt Oreoxmt added v7.6 This PR/issue applies to TiDB v7.6. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Dec 8, 2023
@afeinberg
Copy link
Contributor Author

/assign @Oreoxmt

@Oreoxmt - feel free to merge this if it's good.

@LykxSassinator
Copy link
Contributor

/cc @qiancai

@ti-chi-bot ti-chi-bot bot requested a review from qiancai December 10, 2023 06:47
@Oreoxmt Oreoxmt added the translation/doing This PR's assignee is translating this PR. label Dec 12, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Dec 12, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 14, 2023
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Dec 14, 2023
@afeinberg
Copy link
Contributor Author

Verified that we can change the max CPU dynamically. Adding it to dynamic-config.md

mysql> show config where type="tikv" and name="raftstore.periodic-full-compact-start-max-cpu";
+------+-----------------+-----------------------------------------------+-------+
| Type | Instance        | Name                                          | Value |
+------+-----------------+-----------------------------------------------+-------+
| tikv | 127.0.0.1:20161 | raftstore.periodic-full-compact-start-max-cpu | 0.5   |
| tikv | 127.0.0.1:20160 | raftstore.periodic-full-compact-start-max-cpu | 0.5   |
| tikv | 127.0.0.1:20162 | raftstore.periodic-full-compact-start-max-cpu | 0.5   |
+------+-----------------+-----------------------------------------------+-------+
3 rows in set (0.01 sec)

Signed-off-by: Alex Feinberg <[email protected]>
@afeinberg
Copy link
Contributor Author

@Oreoxmt Thanks for the help! This is my first docs PR. I updated dynamic-config.md, feel free to merge whenever appropriate.

@Oreoxmt Oreoxmt requested a review from qiancai December 21, 2023 02:49
@afeinberg
Copy link
Contributor Author

@qiancai @Oreoxmt thanks for the last updates. This looks good, do I need to do anything else for this to be merged?

Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 28, 2023
Copy link

ti-chi-bot bot commented Dec 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-14 08:27:10.939909633 +0000 UTC m=+517521.977136552: ☑️ agreed by Oreoxmt.
  • 2023-12-28 01:47:55.50091483 +0000 UTC m=+1703166.538141758: ☑️ agreed by qiancai.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 28, 2023

@afeinberg Thanks for your contribution. I will merge this PR after code freeze (Jan 8, 2024)

@afeinberg
Copy link
Contributor Author

@afeinberg Thanks for your contribution. I will merge this PR after code freeze (Jan 8, 2024)

Thanks, @Oreoxmt

@afeinberg
Copy link
Contributor Author

@Oreoxmt it is now 1/9/2024. Can you get this merged? Let me know if there's anything else I can do.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jan 10, 2024

/approve

Copy link

ti-chi-bot bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 10, 2024
@ti-chi-bot ti-chi-bot bot merged commit 645e5f3 into pingcap:master Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.6 This PR/issue applies to TiDB v7.6.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants