-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tikv: document periodic full compaction. #15630
tikv: document periodic full compaction. #15630
Conversation
Signed-off-by: Alex Feinberg <[email protected]>
Signed-off-by: Alex Feinberg <[email protected]>
Signed-off-by: Alex Feinberg <[email protected]>
@tonyxuqqi: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Alex Feinberg <[email protected]>
/assign @tonyxuqqi |
/cc @qiancai |
Co-authored-by: Aolin <[email protected]>
Co-authored-by: Aolin <[email protected]>
Verified that we can change the max CPU dynamically. Adding it to dynamic-config.md
|
Signed-off-by: Alex Feinberg <[email protected]>
@Oreoxmt Thanks for the help! This is my first docs PR. I updated dynamic-config.md, feel free to merge whenever appropriate. |
Co-authored-by: Aolin <[email protected]>
Co-authored-by: Aolin <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Co-authored-by: Grace Cai <[email protected]>
@afeinberg Thanks for your contribution. I will merge this PR after code freeze (Jan 8, 2024) |
Thanks, @Oreoxmt |
@Oreoxmt it is now 1/9/2024. Can you get this merged? Let me know if there's anything else I can do. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Oreoxmt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?